| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Can can I make an injection point wait occur no more than once? |
| Date: | 2025-07-12 01:18:50 |
| Message-ID: | aHG3-kd6LH0S6QKy@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 10, 2025 at 06:58:58PM -0400, Peter Geoghegan wrote:
> On Wed, Jul 9, 2025 at 10:24 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> > Looking at .cirrus.tasks.yml, I bet the key factor is that CI task using
> > debug_parallel_query=regress. I bet the leader is attached to the injection
> > point, but the WARNING is reached in a parallel worker.
>
> Yep, that was it.
Catching up on things a bit. Cool to see that you have found out the
origin of the problem.
> At some point I'll start a new thread with a formal patch proposal,
> that'll include the tests on this thread. I also plan on using
> injection points to write a simple/serial regression test exercising
> the nbtree code that completes an incomplete split (following a hard
> crash/error).
It sounds to me that an ERROR in an SQL and/or isolation test would be
enough. If you are looking at some replay cases, a TAP test would be
the way to go.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-07-12 01:29:42 | Re: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages |
| Previous Message | Paul Jungwirth | 2025-07-11 22:22:01 | Re: Foreign key isolation tests |