Re: Verify predefined LWLocks tranches have entries in wait_event_names.txt

Hi,

On Mon, Jul 21, 2025 at 03:20:55PM -0500, Nathan Bossart wrote:
> On Fri, Jul 18, 2025 at 01:39:15PM +0000, Bertrand Drouvot wrote:
> > +#define PG_BUILTIN_LWTRANCHE(id, name) [id] = name,
> > +#include "storage/lwlocktranchelist.h"
> > +#undef PG_BUILTIN_LWTRANCHE
>
> Why not reuse PG_LWLOCK for this?

I was not sure we'd want add a new file or add those in lwlocklist.h (in which
case 2 macros would have been simpler). As it looks like we are going with a
new file then yeah we can reuse PG_LWLOCK: done in v2 just shared up-thread.

> > + # Stop recording if we reach another section.
> > + last if /^Section:/;
>
> Can we add a note to wait_event_names.txt about the required
> ordering/matching of the non-predefined LWLocks?

Sure, done in v2 too.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com