On Tue, Jul 08, 2025 at 09:49:20AM +0000, Robin Haberkorn wrote:
> I know this has already been committed, but why are we still using
> PG_XML_STRICTNESS_LEGACY in xpath.c? As we are always checking
> pg_xml_error_occurred() this should no longer be necessary.
Are you sure that you can do that? When I looked at this code I was
under the impression that xmlReadMemory() can generate an error and
can go through the error context we set, so the legacy mode counted
for xpath_string() at least.
Perhaps we should just remove the pg_xml_error_occurred() then if
that's confusing, keeping the legacy mode. Or do you have a different
idea in mind?
--
Michael