| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Nathan Bossart <nathan(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. |
| Date: | 2025-07-02 19:44:42 |
| Message-ID: | aGWMKkLhTmCnCO1N@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Jul 02, 2025 at 03:43:02PM -0400, Andrew Dunstan wrote:
> On 2025-07-02 We 2:27 PM, Nathan Bossart wrote:
>> To fix, revert those renames. I could probably get away with only
>> un-renaming the C symbols, but I figured I'd avoid introducing
>> function name mismatches. Also, AFAICT the buildfarm's
>> cross-version upgrade tests do not run the test module tests
>> post-upgrade, else we'll need to properly version the extension.
>
> It doesn't really run any sanity checks at all other than amchecks.. It just
> compares the pre- and post- upgrade dumps (with suitable modifications).
>
> So far that seems to have been enough.
Thanks for confirming.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-07-02 19:48:15 | pgsql: Correctly copy the target host identification in PQcancelCreate. |
| Previous Message | Andrew Dunstan | 2025-07-02 19:43:02 | Re: pgsql: Fix cross-version upgrade test breakage from commit fe07100e82. |