| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: [PATCH] Split varlena.c into varlena.c and bytea.c |
| Date: | 2025-07-02 00:55:22 |
| Message-ID: | aGSDetczSaL-aUD2@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 18, 2025 at 02:13:27PM +0900, Michael Paquier wrote:
> v3 seems sensible here. Thanks for the updated patch.
I did a new pass over that. All the code blocks moved to the new file
are identical. However, it is really easy to miss the change in
bytea_string_agg_transfn() with the removal of makeStringAggState().
This was mentioned upthread but for somebody who reads only the git
diffs that could be surprising.
I have added a note about that in the commit message, for clarity,
and applied the result.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2025-07-02 01:24:25 | Re: Reduce "Var IS [NOT] NULL" quals during constant folding |
| Previous Message | Michael Paquier | 2025-07-02 00:46:42 | Re: A assert failure when initdb with track_commit_timestamp=on |