| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: [PATCH] Split varlena.c into varlena.c and bytea.c |
| Date: | 2025-06-18 05:13:27 |
| Message-ID: | aFJK97U3RXam8SzG@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 16, 2025 at 01:33:20PM +0300, Aleksander Alekseev wrote:
> Thanks, fixed. clangd complained that utils/fmgroids.h is not going to
> be used, as it complained about funcapi.h before. So I choose not to
> include fmgroids.h.
v3 seems sensible here. Thanks for the updated patch.
/* text_name()
* Converts a text type to a Name type.
*/
Not related to this patch, sorry for the regression, just noticed
a nit while looking at the diffs of what you have here.. This one, as
well as name_text(), uses a comment block that is inconsistent with
the format we have in the tree. It's a bit surprising that pgindent
is not picking up that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mats Kindahl | 2025-06-18 05:23:09 | Re: Transactional behavior of pg_create_logical_replication_slot |
| Previous Message | David G. Johnston | 2025-06-18 05:13:07 | Re: Enhance pg_createsubscriber to create required standby. |