| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| Date: | 2025-07-01 04:06:31 |
| Message-ID: | aGNex9zyxmXqCHXy@ip-10-97-1-34.eu-west-3.compute.internal |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On Mon, Jun 30, 2025 at 08:56:43PM +0200, Tomas Vondra wrote:
> In particular it now uses "chunking" instead of "batching". I believe
> bathing is "combining multiple requests into a single one", but we're
> doing exactly the opposite - splitting a large request into smaller
> ones. Which is what "chunking" does.
I do agree that "chuncking" is more appropriate here.
> I plan to push this tomorrow morning.
Thanks!
LGTM, just 2 nit about the commit messages:
For 0001:
Is it worth to add a link to the Kernel Bug report or mentioned it can be
found in the discussion?
For 0003:
"
But with the chunking, introduced to work around the do_pages_stat()
bug"
Do you have in mind to quote the hex commit object name that will be generated
by 0001?
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2025-07-01 04:26:49 | pgsql: Fix typos in comments |
| Previous Message | Michael Paquier | 2025-07-01 00:52:22 | pgsql: Fix typo in system_views.sql's definition of pg_stat_activity |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2025-07-01 04:21:08 | Re: Logical Replication of sequences |
| Previous Message | Amit Kapila | 2025-07-01 04:04:51 | Re: Correct comment atop PublicationPartOpt |