| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| Date: | 2025-06-25 09:00:38 |
| Message-ID: | aFu6tmQ7EVaaNV9K@msg.df7cb.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Re: Bertrand Drouvot
> +/*
> + * Work around Linux kernel bug in 32-bit compat mode: do_pages_stat() has
> + * incorrect pointer arithmetic for more than DO_PAGES_STAT_CHUNK_NR pages.
> + */
> +#if SIZEOF_SIZE_T == 4
I was also missing it in my suggested patch draft, but this should
probably include #ifdef __linux__.
Re: Tomas Vondra
> +#ifdef USE_VALGRIND
> +
> +static inline void
> +pg_numa_touch_mem_if_required(uint64 tmp, char *ptr)
Stupid question, if this function gets properly inlined, why not
always use it as there should be no performance difference vs using a
macro?
Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-06-25 09:22:41 | Re: pgsql: Introduce pg_shmem_allocations_numa view |
| Previous Message | Peter Eisentraut | 2025-06-25 08:59:49 | pgsql: pg_createsubscriber: Rename option --remove to --clean |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-06-25 09:01:43 | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Previous Message | Maxim Orlov | 2025-06-25 08:42:29 | Re: Issue with custom operator in simple case |