| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, "Devulapalli, Raghuveer" <raghuveer(dot)devulapalli(at)intel(dot)com>, Jesper Pedersen <jesperpedersen(dot)db(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Shankaran, Akash" <akash(dot)shankaran(at)intel(dot)com> |
| Subject: | Re: Improve CRC32C performance on SSE4.2 |
| Date: | 2025-06-23 15:05:49 |
| Message-ID: | aFltTRTPOvQYsAnD@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 23, 2025 at 10:51:21AM -0400, Tom Lane wrote:
> This has broken the build completely on my RHEL8 x86_64 box,
> with gcc 8.5.0:
>
> $ ./configure ...
> $ make -s
> pg_crc32c_sse42.c: In function 'pg_comp_crc32c_avx512':
> pg_crc32c_sse42.c:126:25: warning: implicit declaration of function '_mm512_zextsi128_si512'; did you mean '_mm512_castsi128_si512'? [-Wimplicit-function-declaration]
> x0 = _mm512_xor_si512(_mm512_zextsi128_si512(_mm_cvtsi32_si128(crc0)), x0);
> ^~~~~~~~~~~~~~~~~~~~~~
> _mm512_castsi128_si512
It looks like thse weren't added until GCC 10 [0].
> I see similar symptoms on buildfarm animal conchuela, which
> is DragonFly BSD of some vintage or other. Not sure why
> more animals aren't complaining. Anyway, it seems that the
> configure probe to see if this facility is available had
> better be adjusted to match the new code.
Unfortunately, this will probably require more than replacing
_mm512_castsi512_si128 with _mm512_zextsi512_si128 because the latter
doesn't exist.
[0] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83250
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-06-23 15:10:45 | Re: Improve CRC32C performance on SSE4.2 |
| Previous Message | Tom Lane | 2025-06-23 14:51:21 | Re: Improve CRC32C performance on SSE4.2 |