| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | shihao zhong <zhong950419(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixes inconsistent behavior in vacuum when it processes multiple relations |
| Date: | 2025-06-23 15:38:40 |
| Message-ID: | aFl1AB9ofnQrrckV@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 23, 2025 at 08:48:35AM +0900, Michael Paquier wrote:
> Anyway, here is an attempt at leaning all that. I am really tempted
> to add a couple of const markers to force VacuumParams to be in
> read-only mode, even if it means doing so for vacuum() but not touch
> at vacuum_rel() where we double-check the reloptions for the truncate
> and index cleanup options. That would be of course v19-only material.
> Thoughts or opinions?
Is the idea to do something like this for v19 and this [0] for the
back-branches?
I think the recurse-to-TOAST-table case is still broken with your patch.
We should probably move the memcpy() for toast_vacuum_params to the very
top of vacuum_rel(). Otherwise, your patch looks generally reasonable to
me.
[0] https://postgr.es/m/aFRzYhOTZcRgKPLu%40nathan
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maxim Orlov | 2025-06-23 15:40:31 | Issue with custom operator in simple case |
| Previous Message | Jacob Champion | 2025-06-23 15:32:26 | Re: [PoC] Federated Authn/z with OAUTHBEARER |