| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nikita Malakhov <hukutoc(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Custom reloptions in TableAM |
| Date: | 2025-06-21 03:54:15 |
| Message-ID: | aFYs54nGmTeEhPBe@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 20, 2025 at 11:09:01PM +0300, Nikita Malakhov wrote:
> I haven't found any comments on this and implemented
> a mechanism of setting custom reloptions for a relation
> created with Table AM, if needed. These options are stored
> in Relcache and are accessed through the rd_options field.
Your patch touches the backend, but there is no real way to check
whether it is correct. I would suggest revisiting an idea of dummy
table AM module added to src/test/modules/. This has been proposed
one year ago if I recall correctly on pgsql-hackers, and I did argue
that there was little value in having it as long as it does not
provide specific test coverage. The additions you are suggesting to
would be a reason enough for having such a module, IMO, validating the
correctness of what you are proposing.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-06-21 05:29:40 | Re: pg18: Virtual generated columns are not (yet) safe when superuser selects from them |
| Previous Message | Nikita Malakhov | 2025-06-21 03:04:22 | Re: Custom reloptions in TableAM |