| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | shihao zhong <zhong950419(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixes inconsistent behavior in vacuum when it processes multiple relations |
| Date: | 2025-06-19 20:30:26 |
| Message-ID: | aFRzYhOTZcRgKPLu@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 18, 2025 at 02:48:16PM -0400, shihao zhong wrote:
>>> That leads me to think (1) might be the better option, although I'm not too
>>> wild about the subtlety of the fix.
>
> Thanks for your feedback. New patch is attached. I also updated the
> signature of do_analyze_rel for the same reason.
After thinking about this some more, I'm wondering if it would be better to
pursue option (2) because it's a little less invasive (which is important
because this will need to be back-patched). In any case, we have a similar
problem when recursing to the TOAST table, which can be fixed by copying
the params at the top of vacuum_rel().
While testing out the attached patch, I noticed a couple of other
interesting problems in this area [0].
[0] https://postgr.es/m/aFRxC1W_kZU9OjJ9%40nathan
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| vacuum_params_v3.patch | text/plain | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arseniy Mukhin | 2025-06-19 20:33:55 | Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments |
| Previous Message | Nathan Bossart | 2025-06-19 20:20:27 | problems with toast.* reloptions |