| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Rahila Syed <rahilasyed90(at)gmail(dot)com> |
| Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Sami Imseih <samimseih(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add function for creating/attaching hash table in DSM registry |
| Date: | 2025-06-17 18:41:54 |
| Message-ID: | aFG28hZuqhxfGNmr@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 17, 2025 at 11:57:33AM -0500, Nathan Bossart wrote:
> I like this idea, but I took it one step further in the attached patch and
> made the registry entry struct flexible enough to store any type of entry.
> Specifically, I've added a new "type" enum followed by a union of the
> different structs used to store the entry data. I was originally trying to
> avoid this kind of invasive change, but it's not nearly as complicated as I
> feared, and there are benefits such as fewer shared memory things to juggle
> and better sanity checking. It should also be easy to extend in the
> future. WDYT?
Sorry for the noise. I noticed a couple of silly mistakes in v9.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-simplify-creating-hash-table-in-dsm-registry.patch | text/plain | 19.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2025-06-17 18:50:46 | Re: wrong comments in rewriteTargetListIU |
| Previous Message | Jesper Pedersen | 2025-06-17 18:33:40 | Re: minimum Meson version |