| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, rmt(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Improve tab completion for COPY |
| Date: | 2025-06-10 20:33:01 |
| Message-ID: | aEiWfUt9l-ieeZ2N@nathan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 10, 2025 at 12:37:48PM -0700, Masahiko Sawada wrote:
>> > (1) adds tab completion support for the REJECT_LIMIT option, which was
>> > introduced in v18
>> > (2) splits the tab completion logic between COPY FROM and COPY TO to
>> > reflect their different options.
>
> [...]
>
> Given REJECT_LIMIT is a new v18 feature, it seems to me that (1) is an
> oversight of this feature, but I also agree that it's not a bug and
> doesn't block the release.
>
> How does the RMT feel about the change (1)? Nathan, would you be OK with that?
0001 sure seems like an oversight in commit 4ac2a9b to me. In any case, I
argued that we should fix tab completion for unlogged partitioned tables in
v18 [0], and this seems pretty similar.
TBH I'd even say that 0002 is fixing a bug and could be back-patched. I've
added rmt@ here in case Tomas or Heikki feel differently.
[0] https://postgr.es/m/aEH4XYwrlyvjZUvE%40nathan
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2025-06-10 20:58:37 | Re: User timeouts for scheduling functions |
| Previous Message | Nathan Bossart | 2025-06-10 20:21:34 | Re: add function for creating/attaching hash table in DSM registry |