Re: queryId constant squashing does not support prepared statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: queryId constant squashing does not support prepared statements
Date: 2025-05-29 02:30:12
Message-ID: aDfGtKRV-Hnl6vE9@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 28, 2025 at 04:05:03PM -0500, Sami Imseih wrote:
> That's my mistake. I added a new file called normalize.sql to test
> specific normalization scenarios. Added in v7

Thanks. I was not sure that a new file was worth having for these
tests, knowing that select.sql has similar coverage. I have grouped
the new tests into select.sql at the end, and added a few more
scenarios for extended queries with \bindin extended.sql, where I've
reproduced the same issue while playing with external parameters.
Applied the result down to v13, down to where the problem exists for
supported branches.

I still need to review the rest of the patch series..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiro Ikeda 2025-05-29 02:46:41 Re: Assertion failure in smgr.c when using pg_prewarm with partitioned tables
Previous Message Melanie Plageman 2025-05-29 00:07:20 Re: PG 18 release notes draft committed