| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Large expressions in indexes can't be stored (non-TOASTable) |
| Date: | 2025-05-28 02:43:52 |
| Message-ID: | aDZ4aBbJ_vZTMKac@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 27, 2025 at 03:02:52PM -0500, Nathan Bossart wrote:
> Here is what I have staged for commit for the others. I'm hoping to push
> these in the next couple of days.
Thanks for the refreshed versions. Looks sensible to me overall.
+static inline void
+AssertHasSnapshotForToast(Relation rel)
[...]
+ /*
+ * Commit 16bf24e fixed accesses to pg_replication_origin without a
+ * an active snapshot by removing its TOAST table. On older branches,
+ * these bugs are left in place. Its only varlena column is roname (the
+ * replication origin name), so this is only a problem if the name
+ * requires out-of-line storage, which seems unlikely. In any case,
+ * fixing it doesn't seem worth extra code churn on the back-branches.
+ */
+ if (RelationGetRelid(rel) == ReplicationOriginRelationId)
+ return;
As of the back-branches but not HEAD, this shortcut makes sense.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-05-28 03:18:18 | Re: Speed up JSON escape processing with SIMD plus other optimisations |
| Previous Message | wenhui qiu | 2025-05-28 02:30:02 | Re: Standardize the definition of the subtype field of AlterDomainStmt |