Re: queryId constant squashing does not support prepared statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Sami Imseih <samimseih(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: queryId constant squashing does not support prepared statements
Date: 2025-05-24 00:17:14
Message-ID: aDEQCg03y1w-OIGH@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 23, 2025 at 04:29:45PM +0200, Dmitry Dolgov wrote:
> I think it's better to recursively call IsSquashableConst on the nested
> expression (arg or args for FuncExpr). Something like that was done in
> the original patch version and was concidered too much at that time, but
> since it looks like all the past concerns are lifted, why not. Do not
> forget check_stack_depth.

AFAIK, we have already a couple of check_stack_depth() calls during
some node transformations after-parsing. At this level of the code
that would be a new thing..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2025-05-24 00:37:30 Re: Random subscription 021_twophase test failure on kestrel
Previous Message Michael Paquier 2025-05-24 00:13:33 Re: Retiring some encodings?