Re: C11 / VS 2019

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: C11 / VS 2019
Date: 2025-06-03 04:51:06
Message-ID: aD5_OiEKEz2RpYFR@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 02, 2025 at 08:52:00AM -0500, Nathan Bossart wrote:
> On Mon, Jun 02, 2025 at 05:44:12AM +0200, Peter Eisentraut wrote:
>> Summary:
>> 1. require VS 2019
>> 2. use C11
>>
>> Thoughts?
>
> +1

+1 to move on for both of these. I got convinced about the benefits
of C11 and the simplifications we could get from it in the Postgres
code base during your presentation at pgconf.dev.

Dropping VS 2015 and going up to VS 2019 brings other benefits,
__VA_ARGS__ coming in mind. I am wondering what's the state of
locales, actually. We've had some pain with VS 2015 as we lacked
locale_name in _locale_t, for example. That may be worth a second
look to see if some simplifications can happen in this area. I don't
think so at quick glance through the VS docs, unfortunately, but I may
be wrong, of course..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2025-06-03 05:00:01 Re: Non-reproducible AIO failure
Previous Message Michael Paquier 2025-06-03 04:43:15 Re: fix notes about password encryption in pg_authid docs