| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Subject: | Re: Remove unnecessary "lmgr.h" in stat_utils.c |
| Date: | 2025-05-07 00:10:17 |
| Message-ID: | aBqk6Tsex4WP2ho1@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 05, 2025 at 04:33:20PM +0300, Ilia Evdokimov wrote:
> While reviewing the import/export statistics, I noticed that relation
> locking are handled via relation_open() and relation_close() in
> stats_lock_check_privileges(), and no calls to other lock-manager routines
> are actually used there. As a result, the inclusion of the lock-manager
> header
>
> #include "storage/lmgr.h"
>
> is not needed. I have attached a small patch which simply removes that
> include.
True that we try to be clean when it comes to that.
I suspect that this is an artifact from one of the original versions
of the patch compared to what has been committed when this feature has
been discussed. Corey?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Dilger | 2025-05-07 00:11:36 | Re: Adding skip scan (including MDAM style range skip scan) to nbtree |
| Previous Message | Michael Paquier | 2025-05-06 23:52:49 | Re: minor fix related to Auxiliary processes and IO workers |