| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> | 
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org | 
| Subject: | add --sequence-data to pg_dumpall | 
| Date: | 2025-04-29 20:55:08 | 
| Message-ID: | aBE8rHFo922xQUwh@nathan | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
I noticed that I forgot to add --sequence-data to pg_dumpall in commit
9c49f0e, which added the same option to pg_dump.  This option is primarily
intended for use by pg_upgrade, so we will need it if/when we teach
pg_upgrade to use pg_dumpall to dump the databases.  (Right now pg_upgrade
directly calls pg_dump on each database.)
Assuming we want this patch, should we apply it to v18?  It's arguably an
oversight in the pg_dump --sequence-data commit, and pg_dumpall will just
pass the option through to pg_dump, but otherwise there's not a really
strong reason it can't wait.
-- 
nathan
| Attachment | Content-Type | Size | 
|---|---|---|
| v1-0001-pg_dumpall-Add-sequence-data.patch | text/plain | 3.1 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-04-29 21:16:38 | alphabetize long options in pg_dump[all] docs | 
| Previous Message | Jacob Champion | 2025-04-29 20:27:11 | Re: What's our minimum supported Python version? |