| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Large expressions in indexes can't be stored (non-TOASTable) |
| Date: | 2025-04-28 21:29:21 |
| Message-ID: | aA_zMYasoUwNrDx1@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 23, 2025 at 04:44:51PM -0500, Nathan Bossart wrote:
> On Wed, Apr 23, 2025 at 05:33:41PM -0400, Tom Lane wrote:
>> I don't see any comments in this patch that capture the real
>> reason for removing pg_replication_origin's TOAST table,
>> namely (IIUC) that we'd like to be able to access that catalog
>> without a snapshot. I think it's important to record that
>> knowledge, because otherwise somebody is likely to think they
>> can undo this change for $whatever-reason.
>
> D'oh, yes, I'd better add that.
I updated the comment atop the check in the misc_sanity test for system
tables with varlena columns but no toast table. If you were to reintroduce
pg_replication_origin's toast table, you'd have to at least fix the
expected output for this test, so the comment theoretically has a higher
chance of being seen.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Remove-pg_replication_origin-s-TOAST-table.patch | text/plain | 7.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2025-04-28 21:31:21 | Re: Fix slot synchronization with two_phase decoding enabled |
| Previous Message | David E. Wheeler | 2025-04-28 21:14:58 | Re: RFC: Additional Directory for Extensions |