Re: Avoid orphaned objects dependencies, take 3

On Wed, 2026-06-10 at 15:16 +0000, Bertrand Drouvot wrote:
> PFA a new version of v26, it adds a new test as compared to the v26
> previously
> shared.

I'd like to avoid adding lines to AbortTransaction(). Also, I think it
might miss subtransaction aborts, which could be relevant in complex
cases with SPI.

Can you use a structure like:

ProcessUtility()
{
TrackAclTable *prevTrackAclTable = CurrentTrackAclTable;
/* allocates in CurrentMemoryContext */
CurrentTrackAclTable = NewTrackAclTable();

PG_TRY();
{
... rest of ProcessUtility ...
}
PG_FINALLY();
{
FreeTrackAclTable(CurrentTrackAclTable);
CurrentTrackAclTable = prevTrackAclTable;
}
PG_END_TRY();
}

That would avoid the need to create a special memory context; you could
just repalloc() the chunk allocated for the table. It would also mean
you don't have to track the stack frames manually with a counter, just
use a local variable.

Also, are you sure that the two call sites for aclcheck_track_record()
are enough? Or do we need checks in e.g. pg_attribute_aclcheck() as
well?

Regards,
Jeff Davis