| From: | Lars Kanis <lars(at)greiz-reinsdorf(dot)de> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | libpq: Fix wrong connection status on invalid "connect_timeout" |
| Date: | 2019-10-17 18:04:19 |
| Message-ID: | a9b4cbd7-4ecb-06b2-ebd7-1739bbff3217@greiz-reinsdorf.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
libpq since PostgreSQL-12 has stricter checks for integer values in
connection parameters. They were introduced by commit
https://github.com/postgres/postgres/commit/e7a2217978d9cbb2149bfcb4ef1e45716cfcbefb
.
However in case of "connect_timeout" such an invalid integer value leads
to a connection status other than CONNECTION_OK or CONNECTION_BAD. The
wrong parameter is therefore not properly reported to user space. This
patch fixes this by explicit setting CONNECTION_BAD.
The issue was raised on ruby-pg: https://github.com/ged/ruby-pg/issues/302
It originally came up at Heroku:
https://github.com/heroku/stack-images/issues/147
--
Kind Regards,
Lars Kanis
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-wrong-connection-status-on-invalid-connect_timeo.patch | text/x-patch | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lars Kanis | 2019-10-17 20:10:17 | Re: libpq: Fix wrong connection status on invalid "connect_timeout" |
| Previous Message | Julien Rouhaud | 2019-10-17 18:00:15 | Non working timeout detection in logical worker |