Redundant parameter in the get_useful_pathkeys_for_relation

From: Andrei Lepikhov <lepihov(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Redundant parameter in the get_useful_pathkeys_for_relation
Date: 2025-08-26 14:03:35
Message-ID: a9b25673-6fcc-48db-93c5-65f4ae368c84@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Working on an unrelated project, I found that the
get_useful_pathkeys_for_relation routine has redundant parameter
'require_parallel_safe'. This routine is static and is called only once
with the 'true' value. Hence, it is evident that this parameter is a
redundant one. The thread [1] seems not to explain why it is necessary.
Although this function may be reused someday, I propose to remove this
parameter or, at least, clarify why it is required here.
I would also remove the same parameter from the interface of routine
relation_can_be_sorted_early, but it is exported, and someone may
already use it in a loadable module.

See the patch attached.

[1]
https://www.postgresql.org/message-id/flat/CAAaqYe8cK3g5CfLC4w7bs%3DhC0mSksZC%3DH5M8LSchj5e5OxpTAg%40mail.gmail.com

--
regards, Andrei Lepikhov

Attachment Content-Type Size
0001-Remove-redundant-parameter-from-get_useful_pathkeys_.patch text/plain 2.5 KB

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-08-26 14:09:56 Re: Feature request: A method to configure client-side TLS ciphers for streaming replication
Previous Message Konstantin Knizhnik 2025-08-26 13:59:54 Re: Non-reproducible AIO failure