Re: [BUG] pg_stat_statements and extended query protocol

From: David Zhang <david(dot)zhang(at)highgo(dot)ca>
To: Michael Paquier <michael(at)paquier(dot)xyz>, "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUG] pg_stat_statements and extended query protocol
Date: 2023-03-13 21:30:55
Message-ID: a9a26eb0-f8c3-0fbd-b7aa-f789da39d189@highgo.ca
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> It appears you must "make clean; make install" to correctly compile after
>> applying the patch.
> In a git repository, I've learnt to rely on this simple formula, even
> if it means extra cycles when running ./configure:
> git clean -d -x -f
>
Thank you all for pointing out that it needs make clean first. After
make clean followed by recompile with the patch then both make check
from regression test and pg_stat_statements extension report all test
passed. So the current existing test cases can't really detect any
change from this patch, then it would be better to add some test cases
to cover this.

Best regards,

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Koval 2023-03-13 21:36:14 Re: Operation log for major operations
Previous Message Nathan Bossart 2023-03-13 21:16:31 Re: pg_usleep for multisecond delays