Re: Logical Replication WIP

On 20/12/16 08:10, Erik Rijkers wrote:
> On 2016-12-19 08:04, Erik Rijkers wrote:
>> On 2016-12-18 11:12, Petr Jelinek wrote:
>>
>> (now using latest: patchset:)
>>
>> 0001-Add-PUBLICATION-catalogs-and-DDL-v14.patch
>> 0002-Add-SUBSCRIPTION-catalog-and-DDL-v14.patch
>> 0003-Define-logical-replication-protocol-and-output-plugi-v14.patch
>> 0004-Add-logical-replication-workers-v14.patch
>> 0005-Add-separate-synchronous-commit-control-for-logical--v14.patch
>>
>> Sometimes replication (caused by a pgbench run) runs for a few
>> seconds replicating all 4 pgbench tables correctly, but never longer
>> than 10 to 20 seconds.
>>
>
> I've concocted pgbench_derail.sh. It assumes 2 instances running,
> initially without the publication and subsciption.
>
> There are two separate installations, on the same machine.
>

Thanks, this was very useful. We had wrong attribute index arithmetics
in the place where we verify that replica identities match well enough.

BTW that script you have for testing has 2 minor flaws in terms of
pgbench_history - the order by is not unique enough (adding mtime or
something helps) and second, the pgbench actually truncates the
pgbench_history unless -n is added to command line.

So attached is v15, which fixes this and the
ERROR: unexpected command tag "PUBLICATION
as reported by Steve Singer (plus tab completion fixes and doc fixes).

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services