| From: | Alexander Nestorov <alexandernst(at)gmail(dot)com> |
|---|---|
| To: | Maxime Schoemans <maxime(dot)schoemans(at)enterprisedb(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] btree_gist: add cross-type integer operator support for GiST |
| Date: | 2026-09-13 17:43:16 |
| Message-ID: | a95e833c-eba2-4a19-8692-06736df3ba5d@Spark |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hey Andrey!
No worries! And thanks for the review!
About the three points in your email:
1) I modified the test tables, they are now large enough for each index to have internal pages.
2) True, good catch! I added a small helper that prints the Index Cond, Order By and Filter lines
for every cross-type strategy and <-> pair, so a missing pg_amop entry now makes the test fail.
3) I updated the documentation in order to reflect the KNN index scan limitation.
Attaching v7 patchset.
Regards!
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Implement-cross-type-operators-for-GiST-indexes.patch | application/octet-stream | 32.4 KB |
| v7-0002-Add-tests-for-cross-type-operators-for-GiST-indexes.patch | application/octet-stream | 40.9 KB |
| v7-0003-doc-Document-cross-type-operator-support-in-btree_gi.patch | application/octet-stream | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-09-13 18:28:12 | Re: pg_get_*_ddl() needs a redesign |
| Previous Message | Tom Lane | 2026-09-13 17:32:15 | Re: remove_useless_joins vs. bug #19560 |