Re: [HACKERS] Custom compression methods

From: Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>
To: Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Евгений Шишкин <itparanoia(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Chapman Flack <chap(at)anastigmatix(dot)net>
Subject: Re: [HACKERS] Custom compression methods
Date: 2018-01-29 14:29:29
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Ildus,

On 29.01.2018 14:44, Ildus Kurbangaliev wrote:
> Thanks! Attached new version of the patch.

Patch applies cleanly, builds without any warnings, documentation builds
ok, all tests pass.

A remark for the committers. The patch is quite big, so I really wish
more reviewers looked into it for more comprehensive review. Also a
native english speaker should check the documentation and comments.
Another thing is that tests don't cover cmdrop method because the
built-in pglz compression doesn't use it (I know there is an jsonbd
extension [1] based on this patch and which should benefit from cmdrop
method, but it doesn't test it either yet).

I think I did what I could and so passing this patch to committers for
the review. Changed status to "Ready for committer".


Ildar Musin

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2018-01-29 14:31:15 Re: [HACKERS] [PATCH] Vacuum: Update FSM more frequently
Previous Message Pavel Stehule 2018-01-29 14:19:55 Re: [HACKERS] MERGE SQL Statement for PG11