Re: dsm_unpin_segment

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: dsm_unpin_segment
Date: 2016-08-10 02:43:48
Message-ID: a8aeee95-61a4-c5b4-a017-f5077f4b9855@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8/9/16 6:14 PM, Thomas Munro wrote:
>> Could a couple of static variables be used to ensure multiple pin/unpin and
>> > attach/detach calls throw an assert() (or become a no-op if asserts are
>> > disabled)? It would be nice if we could protect users from this.
> The can't be static, they need to be in shared memory, because we also
> want to protect against two *different* backends pinning it.

Right, this would strictly protect from it happening within a single
backend. Perhaps it's pointless for pin/unpin, but it seems like it
would be a good thing to have for attach/detach.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532) mobile: 512-569-9461

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2016-08-10 02:45:26 Re: Heap WARM Tuples - Design Draft
Previous Message Jim Nasby 2016-08-10 02:39:58 Re: Heap WARM Tuples - Design Draft