| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: A few message wording/formatting cleanup patches |
| Date: | 2026-07-03 21:52:20 |
| Message-ID: | a8ad8261-689b-4a43-833d-1dca66437ae7@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02.06.26 08:28, Ashutosh Bapat wrote:
> I like the idea of pfree'ing the string returned by
> getObjectDescriptor() since we also pffree other descriptor strings.
> But just doing it for these changes doesn't look consistent.
>
> Attached patchset with some more changes to bring the new code inline
> with the surrounding code. The changes are
> 1. rename objdesc to rel. The latter is used in the surrounding code.
> 2. getObjectDescriptor() is invoked directly from appendStringInfo.
> 3. Place InitStringInfo() closer to the appendStringInfo call like
> surrounding code
>
> None of these changes are compulsory. If you think any of the changes
> are acceptable to you, please provide a single patch absorbing them
> into your patch. Otherwise, let the committer decide.
>
> 0008 is your patch as is
> 0009 is my cosmetic changes
committed
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-07-03 22:00:16 | Bug in asynchronous Append |
| Previous Message | Dmitry Fomin | 2026-07-03 21:34:26 | Re: [PATCH v1 0/7] Wait event timing and tracing instrumentation |