| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal for internal Numeric to Uint64 conversion function. |
| Date: | 2022-05-03 14:34:47 |
| Message-ID: | a89d395c-ecdf-665f-fb91-24fb7d69f508@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.05.22 08:50, Amul Sul wrote:
>> Do you have any data that supports removing DirectionFunctionCall()
>> invocations? I suppose some performance benefit could be expected, or
>> what do you have in mind?
>>
> Not really, the suggestion to avoid DirectionFunctionCall() is from Tom.
>
> For a trial, I have called the money(numeric) function 10M times to
> see the difference with and without patch but there is not much.
> (I don't have any knowledge of micro profiling/benchmarking).
Ok. I have lost track of what you are trying to achieve with this patch
set. It's apparently not for performance, and in terms of refactoring
you end up with more lines of code than before, so that doesn't seem too
appealing either. So I'm not sure what the end goal is.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-05-03 14:50:29 | Re: testclient.exe installed under MSVC |
| Previous Message | Alvaro Herrera | 2022-05-03 13:58:09 | Re: testclient.exe installed under MSVC |