Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)

From: Zhang Mingli <zmlpostgres(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Subject: Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)
Date: 2022-08-06 15:02:53
Message-ID: a7a237de-a881-4635-9d0f-bd5466e38d4d@Spark
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Aug 6, 2022, 22:47 +0800, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, wrote:
> Zhang Mingli <zmlpostgres(at)gmail(dot)com> writes:
> > I think it’s ok, re_guts is converted when  used
> > (struct guts *) re->re_guts;
> > And there is comments in regex.h
> > char *re_guts; /* `char *' is more portable than `void *' */
>
> Boy, that comment is showing its age isn't it? If we were to do
> anything about this, I'd be more inclined to change re_guts to void*.
Got it , thanks.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-08-06 15:25:09 Re: `make check` doesn't pass on MacOS Catalina
Previous Message Joe Conway 2022-08-06 14:59:26 Re: [PATCH] Expose port->authn_id to extensions and triggers