Re: pgsql: Add support for temporary replication slots

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add support for temporary replication slots
Date: 2016-12-15 13:51:04
Message-ID: a7315da5-fd22-bcbc-0541-8979a586284c@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 12/15/16 3:46 AM, Petr Jelinek wrote:
>>> Okay in case we decide it's the right way to go attached patch does
>>> that. I also added some more tests based on your feedback while I am at it.
>>
>> This looks mostly reasonable to me, but the location and xid output from
>> pg_logical_slot_get_changes() is not portable/repeatable, so it should
>> be omitted from the output.
>>
>
> Sigh, yes you are right.

committed

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2016-12-15 15:47:43 pgsql: Add missing newline in message
Previous Message Peter Eisentraut 2016-12-15 13:50:30 pgsql: Various temporary slots test improvements

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2016-12-15 14:01:12 Re: [OSSTEST PATCH 0/1] PostgreSQL db: Retry on constraint violation [and 2 more messages] [and 1 more messages]
Previous Message Stephen Frost 2016-12-15 13:40:30 Re: pg_authid.rolpassword format (was Re: Password identifiers, protocol aging and SCRAM protocol)