Re: oidin / oidout and InvalidOid

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Chapman Flack <chap(at)anastigmatix(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: oidin / oidout and InvalidOid
Date: 2017-06-12 11:58:30
Message-ID: a72120a7-367f-0f81-4694-4cb215e1dd56@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/12/2017 01:41 PM, Chapman Flack wrote:
> I was recently guilty of writing a less-than-clear SQL example
> because I plain forgot whether InvalidOid was 0 (correct) or -1
> (my bad).
>
> Would there be any sense in letting oidin_subr accept the string
> InvalidOid for 0? I understand that changing oidout could break
> existing code outside of the tree. But what if oidout were to be
> conservative in what it does, and oidin liberal in what it accepts?

I am not sure I am a fan of this, but if we should have an alias for
InvalidOid how about reusing '-' which is used by the reg*in functions?
Or is that too non-obvious?

Andreas

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Kliukin 2017-06-12 12:25:44 Re: Why restore_command is called for existing files in pg_xlog?
Previous Message Ashutosh Bapat 2017-06-12 11:56:21 Dropping partitioned table drops a previously detached partition