Re: reloption to prevent VACUUM from truncating empty pages at the end of relation

From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
To: "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: reloption to prevent VACUUM from truncating empty pages at the end of relation
Date: 2019-02-01 08:11:50
Message-ID: a6f65913f2be581d31c5845202d224011dc6fc1e.camel@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jamison, Kirk wrote:
> On February 1, 2019, Tsunakawa, Takayuki wrote:
>
> > > As most people seem to agree adding the reloption, here's the patch.
> > > It passes make check, and works like this:
> > Sorry, I forgot to include the modified header file. Revised patch attached.
>
> I wonder if there is a better reloption name for shrink_enabled. (truncate_enabled, vacuum_enabled? Hmm. No?)
> On the other hand, shrink_enabled seems to describe well what it's supposed to do when vacuuming tables.
> Besides there's a similarly-named autovacuum_enabled option.

I like "shrink_enabled".

It may sound weird in the ears of PostgreSQL hackers, but will make sense to users.

Perhaps "vacuum_shrink_enabled" would be even better.

Yours,
Laurenz Albe

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-01 08:14:37 Re: initdb --allow-group-access behaviour in windows
Previous Message Andrew Gierth 2019-02-01 07:51:10 Re: LD_LIBRARY_PATH_RPATH