Re: Remove nonmeaningful prefixes in PgStat_* fields

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove nonmeaningful prefixes in PgStat_* fields
Date: 2023-03-20 09:05:21
Message-ID: a6eb68a6-1cfb-9290-ab31-e3bba292d3ac@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 3/20/23 8:32 AM, Michael Paquier wrote:
>
> /* Total time previously charged to function, as of function start */
> - instr_time save_f_total_time;
> + instr_time save_total_time;
> I have something to say about this one, though.. I find this change a
> bit confusing. It may be better kept as it is, or I think that we'd
> better rename also "save_total" and "start" to reflect in a better way
> what they do, because removing "f_" reduces the meaning of the field
> with the two others in the same structure.

Thanks for looking at it!

Good point and keeping it as it is currently would not
affect the work that is/will be done in [1].

So, please find attached V2 attached taking this comment into account.

[1]: https://www.postgresql.org/message-id/flat/89606d96-cd94-af74-18f3-c7ab2b684ba2%40gmail.com

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v2-0001-remove_nonmeaningful_prefixes.patch text/plain 24.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2023-03-20 09:05:41 Re: Fix misplaced shared_preload_libraries_in_progress check in few extensions
Previous Message Amit Kapila 2023-03-20 08:53:48 Re: Data is copied twice when specifying both child and parent table in publication