| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove nonmeaningful prefixes in PgStat_* fields |
| Date: | 2023-03-22 01:28:19 |
| Message-ID: | ZBpZsxwl1pMS2pQL@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 20, 2023 at 10:05:21AM +0100, Drouvot, Bertrand wrote:
> Good point and keeping it as it is currently would not
> affect the work that is/will be done in [1].
I guess that I'm OK with that to get more of pgstatfuncs.c to use
macros for the function definitions there.. Alvaro, Tom, perhaps you
still think that this is unadapted? Based on the file split and the
references to funcentry and tabentry, I think that's OK, but that
stands just as one opinion among many..
> So, please find attached V2 attached taking this comment into account.
> [1]: https://www.postgresql.org/message-id/flat/89606d96-cd94-af74-18f3-c7ab2b684ba2%40gmail.com
Nice. I am pretty sure that finishing some of that is doable by the
end of this CF to reduce the size of pgstatfuncs.c overall.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2023-03-22 01:31:09 | Re: Show various offset arrays for heap WAL records |
| Previous Message | Michael Paquier | 2023-03-22 01:16:12 | Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry |