| From: | Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
|---|---|
| To: | Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [POC] Fast COPY FROM command for the table with foreign partitions |
| Date: | 2020-07-28 00:33:19 |
| Message-ID: | a5729617-c16d-03d8-4b60-3910720e0a46@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
27.07.2020 21:34, Alexey Kondratov пишет:
> Hi Andrey,
>
> On 2020-07-23 09:23, Andrey V. Lepikhov wrote:
>> On 7/16/20 2:14 PM, Amit Langote wrote:
>>> Amit Langote
>>> EnterpriseDB: http://www.enterprisedb.com
>>>
>>
>> Version 5 of the patch. With changes caused by Amit's comments.
>
> Just got a segfault with your v5 patch by deleting from a foreign table.
> It seems that ShutdownForeignScan inside node->fdwroutine doesn't have a
> correct pointer to the required function.
>
> I haven't had a chance to look closer on the code, but you can easily
> reproduce this error with the attached script (patched Postgres binaries
> should be available in the PATH). It works well with master and fails
> with your patch applied.
I used master a3ab7a707d and v5 version of the patch with your script.
No errors found. Can you check your test case?
--
regards,
Andrey Lepikhov
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2020-07-28 00:54:35 | Re: HashAgg's batching counter starts at 0, but Hash's starts at 1. |
| Previous Message | Jeff Davis | 2020-07-28 00:10:41 | Re: Default setting for enable_hashagg_disk |