Re: jit and explain nontext

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: jit and explain nontext
Date: 2020-11-20 15:56:38
Message-ID: a56f853c-e671-c4b1-7e0e-a1f0a18621e4@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-10-17 21:21, Justin Pryzby wrote:
> Added at:https://commitfest.postgresql.org/30/2766/
>
> diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
> index 41317f1837..7345971507 100644
> --- a/src/backend/commands/explain.c
> +++ b/src/backend/commands/explain.c
> @@ -839,7 +839,8 @@ ExplainPrintJIT(ExplainState *es, int jit_flags, JitInstrumentation *ji)
> instr_time total_time;
>
> /* don't print information if no JITing happened */
> - if (!ji || ji->created_functions == 0)
> + if (!ji || (ji->created_functions == 0 &&
> + es->format == EXPLAIN_FORMAT_TEXT))
> return;
>
> /* calculate total time */

Can you show an output example of where this patch makes a difference?
Just from reading the description, I would expect some kind of
additional JIT-related output from something like

EXPLAIN (FORMAT YAML) SELECT 1;

but I don't see anything.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-11-20 15:59:30 Re: xid wraparound danger due to INDEX_CLEANUP false
Previous Message John Naylor 2020-11-20 15:56:15 Re: Should we document IS [NOT] OF?