| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, khuddleston(at)pivotal(dot)io |
| Subject: | Re: Making "COPY partitioned_table FROM" faster |
| Date: | 2018-07-30 18:21:38 |
| Message-ID: | a56db2e7-fbcd-fc43-8158-c6c2dde36f35@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 30/07/2018 15:26, David Rowley wrote:
>> - Add some tests. The if (nBufferedTuples > 0) that flushes the tuples
>> when the partition changes is not currently exercised.
>
> That seems like a good idea. In fact, it uncovered a bug around
> ConvertPartitionTupleSlot() freeing the previously stored tuple out
> the slot which resulted in a crash. I didn't notice before because my
> test had previously not required any tuple conversions.
I think we need to think of a better place to put that temporary file,
and clean it up properly afterwards. I'm not sure whether we have
existing uses like that.
Also, maybe the test should check afterwards that the right count of
rows ended up in each partition?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-07-30 19:06:50 | Re: Expression errors with "FOR UPDATE" and postgres_fdw with partition wise join enabled. |
| Previous Message | Fabien COELHO | 2018-07-30 17:29:31 | Re: Adding a note to protocol.sgml regarding CopyData |