Re: equalPolicy() doesn't compare the permissive flag

From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andreas Lind <andreaslindpetersen(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: equalPolicy() doesn't compare the permissive flag
Date: 2026-07-13 07:49:09
Message-ID: a4d908505127f5aca45cfbccf86b0cbee444919a.camel@cybertec.at
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2026-07-13 at 11:06 +0900, Michael Paquier wrote:
> On Fri, Jul 10, 2026 at 08:58:22AM +0200, Laurenz Albe wrote:
> > I don't know if the omission to check for identical PERMISSIVE or
> > RESTRICTIVE settings can lead to real problems, but I feel that it
> > violates the promise of the function.  So I am +1 on this change.
>
> That does not make sense here, two policies with a different
> polpermissive are not the same, or am I missing something?

I think we agree. I probably did not express myself well.
I am for fixing the function the way Andreas suggested.

I just wasn't sure if the omission was intentional or not;
your research says it was a mistake.

Yours,
Laurenz Albe

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2026-07-13 08:13:58 Re: Re: COPY FROM with RLS
Previous Message Alexander Pyhalov 2026-07-13 06:47:54 Re: postgres_fdw could deparse ArrayCoerceExpr