| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] replace GrantObjectType with ObjectType |
| Date: | 2017-12-15 17:39:16 |
| Message-ID: | a47df7f3-8fb6-1009-3539-0730e0c1b124@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/13/17 02:35, Michael Paquier wrote:
> Patch 0001 is simply removing EventTriggerSupportsGrantObjectType(),
> but shouldn't we keep it and return an error for objects that have no
> GRANT support? Returning conditionally true looks like a trap waiting
> to take someone in.
I don't understand the motivation for this. It would just be two lists
for the same thing. I think the potential for omission would be much
greater that way.
> Similarly, not using default in the switches of
> stringify_adefprivs_objtype() and stringify_grantobjtype() would be
> nice to grab warnings during compilation. And patch 0002 is doing it
> the correct way in aclcheck_error().
I'll fix that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-12-15 17:40:49 | Re: [HACKERS] replace GrantObjectType with ObjectType |
| Previous Message | Peter Eisentraut | 2017-12-15 17:13:20 | Re: [PROPOSAL] bracketed-paste support for psql |