| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "jian he" <jian(dot)universality(at)gmail(dot)com>, "Nathan Bossart" <nathandbossart(at)gmail(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: create table like including storage parameter |
| Date: | 2025-12-15 17:51:49 |
| Message-ID: | a3c6ccf6-3c53-47ab-ad33-fb726a6f1850@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 15, 2025, at 5:48 AM, jian he wrote:
> rebased, with minor comment polishing.
>
I started reviewing this patch. Why don't you reuse untransformRelOptions()?
Even if this function is used by various extensions [1][2], that's not an
excuse to duplicate code. I adjusted the code in the fixup. I did a bunch of
stylish changes and fixed a few typos. I also ran pgindent. I removed some
superfluous comments ("Fetch heap tuple", "Get the toast reloptions",). Don't
think they are saying something important. Coverage looks good. As a homework,
add a nice commit message. Showing how it works is not a good commit message.
This v6 is your v5 plus my suggestions.
[1] https://codesearch.debian.net/search?q=untransformRelOptions&literal=1
[2] https://github.com/search?q=untransformRelOptions&type=code
--
Euler Taveira
EDB https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-create-table-like-incluing-parameters.patch | text/x-patch | 15.2 KB |
| v6-0002-fixup-create-table-like-incluing-parameters.patch | text/x-patch | 12.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-12-15 18:05:35 | pg_dump crash due to incomplete ordering of DO_SUBSCRIPTION_REL objects |
| Previous Message | Andres Freund | 2025-12-15 17:48:25 | Re: relfilenode statistics |