| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improper use about DatumGetInt32 |
| Date: | 2021-01-08 15:54:47 |
| Message-ID: | a3c0e62c-2035-e178-4858-fee72c5193df@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-01-08 10:21, Peter Eisentraut wrote:
> I think on 64-bit systems it's actually safe, but on 32-bit systems
> (with USE_FLOAT8_BYVAL), if you use the new binaries with the old
> SQL-level definitions, you'd get the int4 that is passed in interpreted
> as a pointer, which would lead to very bad things. So I think we need
> to create new functions with a different C symbol. I'll work on that.
Updated patch that does that.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-pageinspect-Change-block-number-arguments-to-bigi.patch | text/plain | 17.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2021-01-08 15:55:51 | Re: data_checksums enabled by default (was: Move --data-checksums to common options in initdb --help) |
| Previous Message | Bruce Momjian | 2021-01-08 15:50:40 | Re: Proposal: Global Index |