Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Allow db.schema.table patterns, but complain about random garbag
Date: 2022-04-22 14:24:27
Message-ID: a3bce10f-0e9b-4d3b-29c7-a150fc44037e@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 2022-04-22 Fr 10:04, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> This has upset the buildfarm's msys2 animals. There appears to be some
>> wildcard expansion going on that causes the problem. I don't know why it
>> should here when it's not causing trouble elsewhere. I have tried
>> changing the way the tests are quoted, without success. Likewise,
>> setting SHELLOPTS=noglob didn't work.
>> At this stage I'm fresh out of ideas to fix it. It's also quite possible
>> that my diagnosis is wrong.
> When I was looking at this patch, I thought the number of test cases
> was very substantially out of line anyway. I suggest that rather
> than investing a bunch of brain cells trying to work around this,
> we just remove the failing test cases.

WFM.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-04-22 20:06:03 Re: pgsql: Allow db.schema.table patterns, but complain about random garbag
Previous Message Tom Lane 2022-04-22 14:04:05 Re: pgsql: Allow db.schema.table patterns, but complain about random garbag

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-04-22 14:56:38 Cryptohash OpenSSL error queue in FIPS enabled builds
Previous Message Bharath Rupireddy 2022-04-22 14:23:44 Re: How to simulate sync/async standbys being closer/farther (network distance) to primary in core postgres?