| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com> |
| Subject: | Re: Bug: COPY FORMAT JSON includes generated columns unlike text/CSV |
| Date: | 2026-04-15 12:36:33 |
| Message-ID: | a2fe8b41-b2ac-4e17-a43b-8cb484796673@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-04-14 Tu 10:46 AM, jian he wrote:
> On Mon, Apr 13, 2026 at 5:21 PM SATYANARAYANA NARLAPURAM
> <satyanarlapuram(at)gmail(dot)com> wrote:
>> Hi hackers,
>>
>> COPY TO with FORMAT json includes generated columns in the output,
>> while text and CSV formats correctly exclude them. Virtual generated
>> columns appear as null (since they aren't materialized), and stored
>> generated columns appear with their values Attached a patch to address this.
>>
> The patch looks good to me.
>
> It seems there's a ``git apply`` issue applying the V1 patch.
> The attached v2 is the same as your v1, it should apply without issue
> using `git apply` or `git am`.
>
Thanks. pushed.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2026-04-15 12:45:01 | Re: Add errdetail() with PID and UID about source of termination signal |
| Previous Message | Andrew Dunstan | 2026-04-15 12:14:52 | Re: Add errdetail() with PID and UID about source of termination signal |