| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | Re: ON CONFLICT DO UPDATE for partitioned tables |
| Date: | 2018-04-18 04:13:38 |
| Message-ID: | a2da1cc8-5c71-4ce0-b47a-3288131de175@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/04/18 0:02, Alvaro Herrera wrote:
> Amit Langote wrote:
>
>> Attached find a patch that does that. When working on this, I noticed
>> that when recursing for inheritance children, ATPrepAlterColumnType()
>> would use a AlterTableCmd (cmd) that's already scribbled on as if it were
>> the original.
>
> While I agree that the code here is in poor style, there is no live bug
> here, because the only thing that is changed each time is the copy's
> cmd->def, and its value is not obtained from the scribbled 'cmd' -- it's
> obtained from the passed-in cmd->def, which is unmodified.
Ah, you're right. The original cmd->def itself remains intact.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-04-18 04:35:02 | Re: ON CONFLICT DO UPDATE for partitioned tables |
| Previous Message | Kyotaro HORIGUCHI | 2018-04-18 04:13:17 | Re: Problem while updating a foreign table pointing to a partitioned table on foreign server |