Re: pg_threads.h take II

On 07/07/2026 00:01, dbryan(dot)green(at)gmail(dot)com wrote:
> On 7/6/26 3:48 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> On 06/07/2026 15:09, Thomas Munro wrote:
>>> +#ifdef WIN32
>>> +
>>> +    /*
>>> +     * Retrieve handle passed here by pg_thrd_create() before
>>> allowing this
>>> +     * thread to run.  (pg_thrd_current() can't use CurrentThread(),
>>> because
>>> +     * that returns a pseudo-handle with the same value in all threads.)
>>> +     */
>>> +    Assert(start_info->self);
>>> +    my_thrd_handle = start_info->self;
>>> +#endif
>>
>> Does that refer to the GetCurrentThreadId() function? We use that in a
>> few places currently.
>>
>> How can it return the same value in all threads, isn't that completely
>> useless? And does that mean all our current uses of it are broken?
>
> GetCurrentThread() not GetCurrentThreadId()...  GetCurrentThread()
> returns a special sentinel handle (-2) that when passed to another
> Win32 function causes the kernel to resolve to whatever thread made
> the call....
>
> So, no-- not broken.

Ah gotcha. Could we use GetCurrentThreadId() here then? (I have no
problem with the way it's currently done in the patch either though,
just curious)

- Heikki