Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pierre Giraud <pierre(dot)giraud(at)dalibo(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, depesz(at)depesz(dot)com, depesz(at)gmail(dot)com
Subject: Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)
Date: 2020-08-21 16:04:04
Message-ID: a2bd31a4-6c9f-61a8-e75a-e03a164dfc08@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/08/21 23:53, Tom Lane wrote:
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>> Pushed. Thanks!
>
> Buildfarm shows this patch has got problems under
> -DRELCACHE_FORCE_RELEASE and/or -DCATCACHE_FORCE_RELEASE:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2020-08-21%2011%3A54%3A12

Thanks for the report!

This happens because, in text format, whether "Planning:" line is output
varies depending on the system state. So explain_filter() should ignore
"Planning:" line. Patch attached. I'm now checking whether the patched
version works fine.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
bugfix.patch text/plain 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ibrar Ahmed 2020-08-21 16:43:46 Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
Previous Message Tom Lane 2020-08-21 14:53:41 Re: [PG13] Planning (time + buffers) data structure in explain plan (format text)