Re: Option to dump foreign data in pg_dump

From: David Steele <david(at)pgmasters(dot)net>
To: Luis Carril <luis(dot)carril(at)swarm64(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Option to dump foreign data in pg_dump
Date: 2020-03-16 14:18:31
Message-ID: a27959ae-dec5-2b21-6829-3c58a7ff013f@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Luis,

Please don't top post. Also be careful to quote prior text when
replying. Your message was pretty hard to work through -- i.e. figuring
out what you said vs. what you were replying to.

On 3/5/20 8:51 AM, Luis Carril wrote:
>
> At this point I would like to leave the patch as is, and discuss further
> improvement in a future patch.

I have marked this as Need Review since the author wants the patch
considered as-is.

I think Ashutosh, at least, has concerns about the patch as it stands,
but does anyone else want to chime in?

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-03-16 14:25:23 Re: ALTER tbl rewrite loses CLUSTER ON index
Previous Message Alvaro Herrera 2020-03-16 14:17:33 Re: error context for vacuum to include block number